search

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
27 stars 41 forks source link

add updater script #43

Closed mio-19 closed 4 years ago

mio-19 commented 4 years ago

fix https://github.com/minetest-mods/skinsdb/issues/38, https://github.com/minetest-mods/skinsdb/issues/31

bell07 commented 4 years ago

I like the script idea. But the script does not work with minetest compiled with RUN_IN_PLACE The RUN_IN_PLACE is recommended for users compiling the minetest from source.

mio-19 commented 4 years ago

Users can download compiled minetest 5.1.1 somewhere

bell07 commented 4 years ago

@SmallJoker, should we merge that? Have concerns about the script is not compatible to the RUN_IN_PLACE version

SmallJoker commented 4 years ago

This solution looks very hacky - and the execution chain bash -> Minetest -> skinsdb -> Skin files -> bash is very fragile. At least the RUN_IN_PLACE exception should be documented (README.md). Generally no objections from my side because I would not use this script anyway.

SmallJoker commented 4 years ago

Superseded by #48