minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
27 stars 41 forks source link

pre-generated preview shows as separate defunct skin #44

Closed Bastrabun closed 4 years ago

Bastrabun commented 4 years ago

To reproduce, put a skin preview file into the textures folder, to force skinsdb to use this pre-generated preview instead of the generated one. It will show in the skin selection formspec as a separate skin. I added a skin and its pregenerated preview, also a screenshot of the error.

I named the skins according to the readme. In my skins there's an additional underscore, but I also tried to replace it with a hyphen. In both cases the preview gets recognized as separate skin.

Windows 10, MT 5.1.0, minetest_game, the only mod activated is skinsdb, release = 2930

character_farmer_m character_farmer_m_preview grafik

bell07 commented 4 years ago

Please check the file names. The preview files are still supported, but needs to be named "*_preview.png" (with underscore, lowercase).

Bastrabun commented 4 years ago

I noticed in the screenshot I have 3d_armor active. I tried without, the same error occurs. Here are my filenames:

character_farmer_m_preview.png character_farmer_m.png

I thought it had something to do with the additional underscores between "farmer" and "m", but the same error occurs when I rename them to

character_farmer_preview.png character_farmer.png

bell07 commented 4 years ago

@Bastrabun, Can you pls. zip your skinsdb folder and upload them?

Bastrabun commented 4 years ago

Sure. Here it comes. skinsdb.zip

bell07 commented 4 years ago

Fixed. Thank you for reporting