search

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
27 stars 41 forks source link

Skins downloader does not work on Minetest 5.3.0 #50

Closed bell07 closed 3 years ago

bell07 commented 3 years ago

Tried the downloader today and got the next error:

2020-09-02 21:41:37: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'skinsdb' in callback environment_Step(): ...est/mods/development-mymodpack/skinsdb/skins_updater.lua:79: bad argument #1 to 'write' (string expected, got nil)
2020-09-02 21:41:37: ERROR[Main]: stack traceback:
2020-09-02 21:41:37: ERROR[Main]:   [C]: in function 'write'
2020-09-02 21:41:37: ERROR[Main]:   ...est/mods/development-mymodpack/skinsdb/skins_updater.lua:79: in function 'unsafe_file_write'
2020-09-02 21:41:37: ERROR[Main]:   ...est/mods/development-mymodpack/skinsdb/skins_updater.lua:99: in function 'safe_single_skin'
2020-09-02 21:41:37: ERROR[Main]:   ...est/mods/development-mymodpack/skinsdb/skins_updater.lua:135: in function 'callback'
2020-09-02 21:41:37: ERROR[Main]:   /usr/share/minetest/builtin/game/misc.lua:243: in function 'func'
2020-09-02 21:41:37: ERROR[Main]:   /usr/share/minetest/builtin/common/after.lua:20: in function </usr/share/minetest/builtin/common/after.lua:5>
2020-09-02 21:41:37: ERROR[Main]:   /usr/share/minetest/builtin/game/register.lua:429: in function </usr/share/minetest/builtin/game/register.lua:413>
2020-09-02 21:41:37: ERROR[Main]: stack traceback:

Seems the core.decode_base64() returns nil. Debug-Prints show me the skin.img is filled. The break is on skin number 2.

SmallJoker commented 3 years ago

Broken by https://github.com/minetest/minetest/pull/9904 Fixed in 5.4.0-dev because I discovered this issue already. https://github.com/minetest/minetest/commit/f34abaed