search

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
28 stars 41 forks source link

Crash on player join #60

Closed ChaosWormz closed 3 years ago

ChaosWormz commented 3 years ago

2021-06-26 07:17:44: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'wieldview' in callback environment_Step(): ...netest/worlds/Bananaland_World/worldmods/skinsdb/api.lua:8: attempt to call method 'get_string' (a nil value) 2021-06-26 07:17:44: ERROR[Main]: stack traceback: 2021-06-26 07:17:44: ERROR[Main]: ...netest/worlds/Bananaland_World/worldmods/skinsdb/api.lua:8: in function 'get_player_skin' 2021-06-26 07:17:44: ERROR[Main]: ...etest/worlds/Bananaland_World/worldmods/skinsdb/init.lua:47: in function 'update_player_visuals' 2021-06-26 07:17:44: ERROR[Main]: ...and_World/worldmods/minetest-3d_armor/wieldview/init.lua:64: in function 'update_wielded_item' 2021-06-26 07:17:44: ERROR[Main]: ...and_World/worldmods/minetest-3d_armor/wieldview/init.lua:75: in function 'func' 2021-06-26 07:17:44: ERROR[Main]: /usr/share/minetest/builtin/common/after.lua:20: in function </usr/share/minetest/builtin/common/after.lua:5> 2021-06-26 07:17:44: ERROR[Main]: /usr/share/minetest/builtin/game/register.lua:425: in function </usr/share/minetest/builtin/game/register.lua:409>

Reported here as well: https://github.com/minetest-mods/3d_armor/issues/55

bell07 commented 3 years ago

Duplicate

bell07 commented 3 years ago

https://github.com/minetest-mods/skinsdb/issues/61 should fix the issue. Or just remove all compatibility lines with playermeta

BuckarooBanzay commented 3 years ago

61 should fix the issue. Or just remove all compatibility lines with playermeta

If the code gets called (and fails) then the compat is still needed, right? :thinking:

bell07 commented 3 years ago

You are Right... I just merge your change

bell07 commented 3 years ago

Should be fixed now. Thank you @BuckarooBanzay