search

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
28 stars 41 forks source link

UI Improvements #7

Closed bell07 closed 6 years ago

bell07 commented 6 years ago

Reopens #6 because of git command line trouble. Please review (anyone) before I merge them

Includes previous PR #5 for issue #2 formspec parts consolidated to formspec.lua removing redundancy unified_inventory supports private skins now, fixes #3 new chat command /skinsdb show to show current skin info in a formspec new chat command /skinsdb show to show skin info in a formspec new chat command /skinsdb ui (or just /skinsdb) to show select skin in formspec without inventory

bell07 commented 6 years ago

Thanks for review. Both solved. In addition added intllib support to the chat commands in the same way as done in formspecs. Translated to german

bell07 commented 6 years ago

Is this PR approved to be merged?

sofar commented 6 years ago

There's a lot mixed up in this PR. I wouldn't merge a PR that looks like this. Do you need help cleaning it up and rebasing it?

bell07 commented 6 years ago

I did a rebase to the current master. See 3 enhancements: chatcommands, UI consolidation and Malay/German translations, but all aofthem are depending on each other, so I do not see the reason or the right way how to split them. Please help me if you still see something to do.

sofar commented 6 years ago

This looks better already. @SmallJoker let's just merge this?