search

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
28 stars 41 forks source link

Remove mesh hand node when player exits #84

Closed MrRar closed 1 year ago

MrRar commented 1 year ago

When the skinsdb mod is disabled, players who logged in when the mod was enabled get a unknown node hand item. This PR removes the mesh hand node when players exit the game or when the server shuts down.

bell07 commented 1 year ago

Pls move the code into init.lua. The skin_meta_api.lua is for skin object methods only. You can enhance already existing minetest.register_on_leaveplayer()entry in init.lua.

MrRar commented 1 year ago

Pls move the code into init.lua. The skin_meta_api.lua is for skin object methods only. You can enhance already existing minetest.register_on_leaveplayer()entry in init.lua.

Done.

ronoaldo commented 1 year ago

This looks good to me, looks like a very small change to be merged.

SmallJoker commented 1 year ago

LGTM as well :+1: , thus merging.

kilbith commented 1 year ago

Please make a new release on CDB.

SmallJoker commented 1 year ago

@bell07 What's the difference between the contentdb and master branch? Why not use master directly?

kilbith commented 1 year ago

Capture d’écran du 2023-04-02 15-46-49

bell07 commented 1 year ago

Contentdb branch contain some useful additional skins. Master is just the mod without skins.

bell07 commented 1 year ago

since I am away from minetest, is it possible to setup automatical merge of master changes into contentdb branch?

SmallJoker commented 1 year ago

Hmm yes, I suppose providing a subset of skins to get started for user-facing packages seems useful. I'll merge master for now but a long-term solution would be better for sure (although I do not know how exactly).