search

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
28 stars 41 forks source link

replace skinsdb api source #91

Closed wsor4035 closed 10 months ago

wsor4035 commented 10 months ago

fixes https://github.com/minetest-mods/skinsdb/issues/88 (minetest chatcommand though)

this minimally gets it just working(not perfect). also removes preview download since the mod can auto do this itself.

ask for improvements if you wish

wsor4035 commented 10 months ago

yes, the api domain should really be config variable driven, but....yeah(lazy)

dax-er commented 10 months ago

I'll close #90 as this will replace the source. Will you update the script too?

wsor4035 commented 10 months ago

commenting to say a WIP homepage that is static/read only exists at https://skinsdb.terraqueststudios.net now. ill get to the python script hopefully today

EDIT: done

wsor4035 commented 10 months ago

@CallMeDax see latest commit

additionally fixed the lua version so it would actually get all the skins

SmallJoker commented 10 months ago

Thanks for the changes. Mod-wise I am happy now. There's however a bug in your API:

newline

The newline should not be there. It breaks the meta saving. The author now shows up in the "License" field.

wsor4035 commented 10 months ago

Thanks for the changes. Mod-wise I am happy now. There's however a bug in your API:

newline

The newline should not be there. It breaks the meta saving. The author now shows up in the "License" field.

forgot to say i fixed this earlier