search

minetest-mods / technic

Technic mod for Minetest
Other
145 stars 155 forks source link

Fix radiation protection when armor group is not set #509

Closed coil0 closed 4 years ago

coil0 commented 5 years ago

The radiation damage group can be not set when armor completely protects against radiation or when no mod has set a default value for the damage group. We want to apply radiation damage in the second case but not in the first. Previously this worked because the damage group was set to 0 in the first case, but this was changed by minetest/minetest#8751 and calculate_damage_multiplier wrongly treated differently the damage group value being 0 and not set.

SmallJoker commented 5 years ago

Well dunno. If it fixes the issue :+1: Will merge in the next few days if there are no change requests.

BobFred7 commented 4 years ago

Will merge in the next few days if there are no change requests.

It's been a few months and there have been no changes

SmallJoker commented 4 years ago

@BobFred7 I simply lost track of this PR, sorry. Please @ ping me in case I forget to comment or merge a PR.