search

minetest-mods / technic

Technic mod for Minetest
Other
145 stars 155 forks source link

Use MT5 builtin’s translation system on all the modpack #529

Open louisroyer opened 4 years ago

louisroyer commented 4 years ago

If you are using an already created map to test this PR, you may need to break and replace some nodes (like chests) to see effects.

louisroyer commented 4 years ago

@louisroyer TODO:

louisroyer commented 4 years ago

Note: some strings on battery box nodes overflow the formspec (but it is not a regression since this also occurs on master). Must I fix the size of the formspec in this PR (by extending on the right) or do it in another one? example: 2020-08-12-214801_536x539_scrot

auouymous commented 4 years ago

Instead of increasing formspec width, those two lines could be moved below the upgrade slots and power level. The digiline channel button could be moved to the right or left side of the upgrade slots.

BuckarooBanzay commented 4 years ago

Instead of increasing formspec width, those two lines could be moved below the upgrade slots and power level. The digiline channel button could be moved to the right or left side of the upgrade slots.

can't this be done in another PR? This one is about translations only.

louisroyer commented 4 years ago

can't this be done in another PR? This one is about translations only.

ok, I created a new issue https://github.com/minetest-mods/technic/issues/562 and will fix this in another PR.

louisroyer commented 3 years ago

Rebased and removed unused/duplicates translations.

SmallJoker commented 2 years ago

Sorry, I didn't remember there was a PR to change the translation system.

Would you - at any chance - have time to rebase this PR? To reduce additional work, it might make sense to reorder and squash related commits using git rebase -i HEAD~20. Also feel free to open a PR per mod, if you'd prefer to split the work.

EDIT:

Note: some strings on battery box nodes overflow the formspec

Yes, I am aware of that, but fixing it belongs to another PR.

louisroyer commented 2 years ago

I will try to have a look at this before the end of the month.

SmallJoker commented 1 year ago

@louisroyer Would you like to continue on this PR sometime?