minetest-mods / technic

Technic mod for Minetest
Other
145 stars 155 forks source link

Change from intllib to minetest translations and update Spanish #535

Closed ghost closed 4 years ago

louisroyer commented 4 years ago

529 also adds more translation strings related to chest:register and fixes some issues with wrought iron conversion. You may want to add your spanish translation improvement over this PR instead.

ghost commented 4 years ago

I didn't find #529 before, I don't know how to add it, because it lacks strings to translate, like the names of the digiline channels example: @ 1_battery_box technic/machines/register/battery_box.lua 318

louisroyer commented 4 years ago

This string is used with

meta:set_string("channel", ltier.."_battery_box"..minetest.pos_to_string(pos))

channel is used by digiline and acts as an unique identifier. I may be wrong, but I think this string is never displayed and is used for internal purpose only. Even if it were printed, it may break things with digiline because users would not be able to write correctly this identifier in digiline code (using mesecon's luacontroller).

If they are any other string I forgot, please let me know.

ghost commented 4 years ago

That string is displayed when the drum channel is edited, the player can change it at any time. Screenshot_20200313_142307 Switching station also has a switching_station.lua 46

louisroyer commented 4 years ago

This means if you translate this string, its actual (=internal) initial value will be @technic)lv_battery_box(-32,3,65). If the player do not edit this, and try to create a program in luacontroller using the displayed identifier caja_de_bateria_bv(-32,3,65), the program will not work until the channel is edited. Translating the default channel name without breaking this require server side translation, but minetest translation api provide client side translation. The case of switching station is similar to this one.

ghost commented 4 years ago

you're right, it should be blank as the force field because it can't be translated and there are players who think they are untouchable values