search

minetest-mods / technic

Technic mod for Minetest
Other
145 stars 155 forks source link

Chainsaw update (bushes and moretrees fixed) #551

Closed dokutan closed 4 years ago

dokutan commented 4 years ago

This fixes the chainsaw support for moretrees and adds the default bushes.

SmallJoker commented 4 years ago

The more often I see those fix PRs the more I think about automating the registration. It would be very helpful when all nodes with the tree or leaves group could be added so that this list becomes rather superfluous. Just thinking loud - the changes look good.

dokutan commented 4 years ago

The chainsaw now checks if the node is either in the list or belongs to the tree or leaves group. I have not touched the list (yet) as it might be useful to keep the known nodes for compatibility. Also the list is obviously still required for all nodes that should be sawed but don't belong to either group (fruit and other decoration).

dokutan commented 4 years ago

The shortened version looks great. Because i got annoyed by floating snow during testing, i have added a call to check_for_falling. From your side, is there anything else that should be done before merging?

SmallJoker commented 4 years ago

From your side, is there anything else that should be done before merging?

No, it looks good. I'll wait a few days so that testers have the chance to test the PR before it's merged. Just in case there are side-effects of the group check function.