search

minetest-mods / technic

Technic mod for Minetest
Other
145 stars 155 forks source link

Latest Technic commit (88f4253) fails on latest Minetest 5.3.0-dev-4f9ccd89b-dirty : Invalid field "inventory_image" (expected string got table) #552

Closed popsUlfr closed 4 years ago

popsUlfr commented 4 years ago

Hello,

I'm not sure if the issue lies in technic, pipeworks or minetest but register_item_raw expected a string but was given a table instead. I wasn't really planning on using minetest from the master branch but since 5.2.0 there have been some important fixes for arm64 so I noticed that technic and pipeworks were failing.

$ minetest --version
Minetest 5.3.0-dev-4f9ccd89b-dirty (Linux)
Using Irrlicht 1.8.4
BUILD_TYPE=Release
RUN_IN_PLACE=0
USE_GETTEXT=1
USE_SOUND=1
USE_CURL=1
USE_FREETYPE=1
USE_LUAJIT=1
STATIC_SHAREDIR="/usr/share/minetest"
STATIC_LOCALEDIR="/usr/share/locale"

Git commits :

debug.txt : 

2020-05-07 15:07:22: ERROR[Main]: ModError: Failed to load and run script from /home/popsulfr/.minetest/mods/pipeworks/init.lua:
2020-05-07 15:07:22: ERROR[Main]: Invalid field "inventory_image" (expected string got table).
2020-05-07 15:07:22: ERROR[Main]: stack traceback:
2020-05-07 15:07:22: ERROR[Main]:   [C]: in function 'register_item_raw'
2020-05-07 15:07:22: ERROR[Main]:   /usr/share/minetest/builtin/game/register.lua:182: in function 'register_item'
2020-05-07 15:07:22: ERROR[Main]:   /usr/share/minetest/builtin/game/register.lua:208: in function 'really_register_node'
2020-05-07 15:07:22: ERROR[Main]:   ...psulfr/.minetest/mods/technic/technic_worldgen/nodes.lua:151: in function 'really_register_node'
2020-05-07 15:07:22: ERROR[Main]:   ...sulfr/.minetest/mods/technic/technic_worldgen/crafts.lua:161: in function 'register_node'
2020-05-07 15:07:22: ERROR[Main]:   .../popsulfr/.minetest/mods/pipeworks/tube_registration.lua:147: in function 'register_one_tube'
2020-05-07 15:07:22: ERROR[Main]:   .../popsulfr/.minetest/mods/pipeworks/tube_registration.lua:189: in function 'register_all_tubes'
2020-05-07 15:07:22: ERROR[Main]:   .../popsulfr/.minetest/mods/pipeworks/tube_registration.lua:228: in function 'register_tube'
2020-05-07 15:07:22: ERROR[Main]:   /home/popsulfr/.minetest/mods/pipeworks/routing_tubes.lua:15: in main chunk
2020-05-07 15:07:22: ERROR[Main]:   [C]: in function 'dofile'
2020-05-07 15:07:22: ERROR[Main]:   /home/popsulfr/.minetest/mods/pipeworks/init.lua:119: in main chunk
2020-05-07 15:07:22: ERROR[Main]: Check debug.txt for details.
2020-05-07 15:07:22: ACTION[Main]: Server: Shutting down
dokutan commented 4 years ago

From the debug.txt this seems to be an issue with pipeworks, therefore i would open an issue at the pipeworks repo.

popsUlfr commented 4 years ago

I found out that several mods actually fail like this. :(

It's because of this commit : https://github.com/minetest/minetest/commit/be71e70a91a3c857652a8b037dac7adf9d0fcdd1 Reverting it makes it work.

Seems that the issue needs to be taken upstream.

Sorry for the noise.

EDIT:

Pipeworks issue is here : https://gitlab.com/VanessaE/pipeworks/-/issues/28