Add LV lights - Githubissues

minetest-mods / technic

Technic mod for Minetest

Other

146 stars 155 forks source link

Add LV lights #598

Closed blockhead100 closed 1 year ago

blockhead100 commented 2 years ago

New lights like technic + and some new textures for hv tools!!

blockhead100 commented 2 years ago

i removed the HV tools but left the textures.

blockhead100 commented 2 years ago

i messed up readme and modpack.conf, so i fixed those.

blockhead100 commented 2 years ago

For my server i wanted the quarry to go deeper, i made that change and forgot to change it back.

SmallJoker commented 2 years ago

:-1:

The small LEDs do not look good; it should cover the cable entirely at least on one side
Either the LED or LV lamp have wrong sunlight_propagates/paramtype values. Placing them next to each other results in weird shadows
LV lamps could be a lot thinner for the small light they can actually produce

Generally it might be interesting to use moreblocks' glow light or lamp to power. The white ones look quite nice and do cover up the cables (for example on the ceiling).

PS: Please do not misunderstand me. It's a good idea to add light sources, but perhaps with another appearance.

blockhead100 commented 2 years ago

Ok... so you think a the textures and the sunlight_propagates/paramtype values should be changed?

blockhead100 commented 2 years ago

I am working on the textures. in making the leds flatter and thinner to cover up the wires.

SmallJoker commented 1 year ago

Sorry, I did not notice that you were done. Feel free to @ me when I ever forget things.

I could not apply the patch, thus squashed & rebased the branch. Now it appears that GitHub lost track of it, hence I uploaded it to https://github.com/minetest-mods/technic/tree/lv_lights to continue development on my own :confused: .

SmallJoker commented 1 year ago

Merged.

blockhead100 commented 1 year ago

Ok thanks so much!!