search

minetest-mods / technic

Technic mod for Minetest
Other
146 stars 155 forks source link

Add grinding recipe for nether lump + refactor grinder recipes #638

Closed gabriel1379 closed 2 months ago

gabriel1379 commented 3 months ago

Hi,

I'm also using the nether mod and wanted to be able to grind nether lumps, so I added a recipe for it.

Also, since I was already at the file and saw that it was getting bigger and harder to overview, refactored it a bit to make it more compact and easier to handle.

(Also, the .png image has been crushed.)

Desour commented 3 months ago

Please note that there is more than one nether mod. Using minetest.get_modpath alone is not enough to check for the right one.

gabriel1379 commented 3 months ago

Please note that there is more than one nether mod. Using minetest.get_modpath alone is not enough to check for the right one.

Thanks for the hint. Additional check added (also to the other PR). Please check and let me know if that's OK or if anything else is needed.

Desour commented 3 months ago

Please check and let me know if that's OK or if anything else is needed.

To be clear, I'm not a maintainer of this mod, I just wanted to make sure it doesn't get incompatible with some mods. :)

gabriel1379 commented 3 months ago

Please check and let me know if that's OK or if anything else is needed.

To be clear, I'm not a maintainer of this mod, I just wanted to make sure it doesn't get incompatible with some mods. :)

Ah, ok. Still, thanks for the hint. :)

SmallJoker commented 2 months ago

Please note that there is more than one nether mod. Using minetest.get_modpath alone is not enough to check for the right one.

(similar argumentation as in #639) For recipes it does not matter which version of the nether` mod is enabled. The worst case is not being able to craft the item (e.g. missing ingredient).

Hence I think it is fine to keep it simple for now.

LGTM. Will merge this PR in a few days unless there are objections.