search

minetest-mods / trash_can

A mod that adds trash cans to minetest.
MIT License
7 stars 10 forks source link

My adjustments for whynot game #5

Closed bell07 closed 5 years ago

bell07 commented 5 years ago

I did 2x changes to add the mod to the whynot game as requested in https://github.com/bell07/minetest-game-whynot/issues/10

1 commit: the default.node_sound_metal_defaults() should not be overriden globally 2 commit: Be able to disable the hacky throw-in function (overrides __builtin:item)

I was not able to hit the trash can with the function, and do not like the idea all items are checked for trash. There is a to-do to port the function to node-timers and minetest.get_objects_inside_radius() but it is not my task.

SmallJoker commented 5 years ago

LGTM. Will merge in a few days unless there are comments/change requests.