[DON'T SQUASH] Some improvements and fixes [WIP]

minetest-mods / unified_inventory

An extensible inventory mod which allows searching crafting and browsing for recipes in the same dialogue.

Other

50 stars 38 forks source link

[DON'T SQUASH] Some improvements and fixes [WIP] #152

Closed MoNTE48 closed 2 years ago

MoNTE48 commented 4 years ago

!!! WIP !!! 1) Cleanup 2) Code-style improvements 3) item_names: do not handle MultiCraft client 4) Fix Teleport sounds when teleport fails (https://github.com/minetest-mods/unified_inventory/issues/137) 5) ...

Fixes #137.

Panquesito7 commented 4 years ago

@MoNTE48 in the first post add Fixes #137. Also, rebase is needed, please rebase.

MoNTE48 commented 4 years ago

I hope to find some time and finish the PR later. And also move item_names commit to a separate PR.

SmallJoker commented 2 years ago

Sorry for neglecting this PR. In the meantime, the teleporting sounds were fixed by you ( f254269 ) and the code has seen quite some cleanups. If there's any changes that still need to be done, feel free to open a new PR. Rebasing might be slower in this case.