search

minetest-mods / unified_inventory

An extensible inventory mod which allows searching crafting and browsing for recipes in the same dialogue.
Other
50 stars 38 forks source link

The git version has an invalid use of the NS function. #187

Closed Poikilos closed 1 year ago

Poikilos commented 2 years ago

There may be visible (or worked-around by not using recipe_text table) glitches of "Recipe @1 (@2)" and "Usage @1 (@2)" where the numbers should actually be items (name (id)). The NS function takes 4 params (See intllib/doc/developer.md). The only reason intllib didn't crash in catngettext (due to null n param) is that register.lua made NS into a do-nothing function and intllib was never called.

SmallJoker commented 1 year ago

Unified Inventory now uses the Minetest translation API.

Poikilos commented 1 year ago

Unified Inventory now uses the Minetest translation API.

That's why I was removing dead code...I'm confused why everyone wants to keep it so much.

fluxionary commented 1 year ago

That's why I was removing dead code...I'm confused why everyone wants to keep it so much.

sorry, not familiar w/ that effort. where were you trying to remove dead code?

Poikilos commented 1 year ago

@fluxionary Here: https://github.com/minetest-mods/unified_inventory/pull/188 The commit further up that mentions the issue is an earlier one that doesn't remove the invalid code completely. The PR is completed.

Poikilos commented 1 year ago

@fluxionary (but rejected)