minetest-mods / unified_inventory

An extensible inventory mod which allows searching crafting and browsing for recipes in the same dialogue.
Other
50 stars 38 forks source link

aliased crafting materials appears not to be handled properly #207

Closed fluxionary closed 2 years ago

fluxionary commented 2 years ago

for example, homedecor defines the following recipe:

-- homedecor.materials.slab_wood = "stairs:slab_wood"

minetest.register_craft( {
        output = "homedecor:bench_large_2_left",
        recipe = {
                        { "homedecor:shutter_oak", "homedecor:shutter_oak", "homedecor:shutter_oak" },
                        { "group:wood", "group:wood", "group:wood" },
                        { homedecor.materials.slab_wood, "", homedecor.materials.slab_wood }
        },
})

a PR i've been writing for moreblocks (https://github.com/minetest-mods/moreblocks/pull/191) aliases stairs:slab_wood to default:slab_wood_8.

the result is that the wooden bench is still craftable, but doesn't appear in the list of recipes that unified_inventory lists:

screenshot_20220725_100737 screenshot_20220725_100748

fluxionary commented 2 years ago

then again, homedecor:shutter_oak is aliased to homedecor:shutter and homedecor:bench_large_2_left is aliased to homedecor:bench_large_2, and i'm uncertain what's different about the aliases in the case of the slabs

fluxionary commented 2 years ago

figured this out, not a problem w/ unified_inventory. i was setting the not_in_craft_guide group.