minetest-mods / unified_inventory

An extensible inventory mod which allows searching crafting and browsing for recipes in the same dialogue.
Other
50 stars 38 forks source link

remove dependency on farming #219

Closed fluxionary closed 1 year ago

fluxionary commented 1 year ago

currently, there is an optional dependency on farming, in order to craft inventory bags out of cotton and string. this is not needed - the recipes will continue to function when farming is present, whether this mod depends on it or not.

depending on farming causes problems. farming depends on stairs. if i want to create an alternate "stairs" implementation which registers custom recipe types with unified inventory, we now have a dependency cycle.

ideally the bags (content) should be excised from the core of unified_inventory, which should just be an API, but that's a lot of work.

SmallJoker commented 1 year ago

Please add a note to the relevant crafting recipes that an optional dependency is intentionally not added to the mod.conf file due to possible circular dependencies

fluxionary commented 1 year ago

Please add a note to the relevant crafting recipes that an optional dependency is intentionally not added to the mod.conf file due to possible circular dependencies

will do, but crafting recipes are never hard dependencies, and i think it should be normal to treat them that way.

SmallJoker commented 1 year ago

Neither is faming a hard dependency. It's a recommendation to have the best experience with unified_inventory to not miss out on bags (unless another recipe is added). I suppose such a note does not matter too much because this repository is barely ever updated.

Will merge soon (TM)

fluxionary commented 1 year ago

hard dependency

i think we're on the same page, but i think i should have said something like "explicit dependency" instead of "hard dependency". in this ontology, optional dependencies are also explicit dependencies.