minetest-mods / unified_inventory

An extensible inventory mod which allows searching crafting and browsing for recipes in the same dialogue.
Other
50 stars 39 forks source link

some recipes using groups with no match still show the group as an unknown item #242

Open fluxionary opened 10 months ago

fluxionary commented 10 months ago

the fix for #218 (#223) apparently doesn't solve the problem for all recipes, though it does fix the recipe in that issue, which i was using for testing. in particular, the recipes from the beacons mod still have issues:

local color = "red" -- example
local color_group = "excolor_" .. color

minetest.register_craft({
    output = "beacons:base_" .. color,
    recipe = {
        {"default:steel_ingot", "group:" .. color_group, "default:steel_ingot",},
        {"default:steel_ingot",      "default:meselamp", "default:steel_ingot",},
        {"default:steel_ingot",   "default:steel_ingot", "default:steel_ingot",},
    },
})

minetest.register_craft({
    type = "shapeless",
    output = "beacons:base_" .. color,
    recipe = {"group:beacon_base", "group:" .. color_group},
})

image

image

SmallJoker commented 10 months ago

223 addresses the ingredient lookup when using the "copy to craft grid" functionality and possibly also the group filter in the craft recipe upon click.

I assume those functions still work properly and the group simply lacks a proper icon in the guide?

fluxionary commented 10 months ago

https://github.com/minetest-mods/unified_inventory/pull/223 addresses the ingredient lookup when using the "copy to craft grid" functionality and possibly also the group filter in the craft recipe upon click.

i haven't dug into the cause, but the problem still exists when i'm using that commit or the most recent commit.

fluxionary commented 10 months ago

replication should just be using minetest game with the beacons mod and unified_inventory installed

SmallJoker commented 10 months ago

@fluxionary Which mod provides dyes with the group excolor_* ?

A few years ago excolor_* was removed from the MTG dyes. Wuzzy already complained about that: https://github.com/minetest/minetest_game/issues/2203

fluxionary commented 10 months ago

Which mod provides dyes with the group excolor_*

none that i know of. the expected behavior if there isn't a match should be to not show the recipe, i think.