search

minetest-mods / woodcutting

GNU Lesser General Public License v3.0
7 stars 8 forks source link

Command to toggle woodchopping. #5

Closed fluxionary closed 5 years ago

fluxionary commented 5 years ago

Forward: this commit contains several changes; I can re-submit them individually if requested.

Players on our server complained that woodchopping still makes it too easy to accidentally destroy structures you're building out of logs. My solution is to add a command to toggle whether woodchopping is enabled for that player. This setting is persisted in mod_storage.

This PR also

  1. contains thomasrudin's nil checks
  2. allows configuring the mod through settings instead of editing the source file
  3. kills a player's active process if they leave the server
bell07 commented 5 years ago

The thomasrudin's nil checks is handled in #4, please remove it from this PR.

By the way, from my opinion the situation should be impossible and the Fix #4 not needed. See my comment https://github.com/minetest-mods/woodcutting/pull/4#issuecomment-522530274. I need to understand the issue first, otherwise it is just an workaround. Did you already got the error message "[woodcutting] unknown Item: " in your log? Which item is reported? What did you digged to get the issue? Any Idea what happens?

Other changes in this PR are fine for me. Thank you!

fluxionary commented 5 years ago

Sorry, I missed the conversation in that other PR. I've removed TR's commits.