search

minetest-mods / xdecor

A decoration mod for Minetest meant to be light, simple and well-featured
Other
29 stars 45 forks source link

fix workbench inv movement bug #114

Closed fluxionary closed 5 years ago

fluxionary commented 5 years ago

Currently, if you move all or part of a stack of items from the "cut" area of the workbench directly into the "storage" area, the microblock "output" area is not properly updated, allowing you to respectively crash the server or duplicate items. This fix ensures that the output area is properly updated on a move.

I also added code to check for protection violations while I was in there.

kilbith commented 5 years ago

I'm against ownership checking and logging for itemstack moves in xdecor.

fluxionary commented 5 years ago

@kilbith for just the moves, or do you also mean the puts/takes? I can remove that stuff, but I'm curious why you would be against either ownership checking or logging.

kilbith commented 5 years ago

do you also mean the puts/takes?

Yes.

If you want to secure your node, place it in a secure room. I don't adhere to the "owner exclusivity" philosophy, everyone can use the same workbench IRL.

fluxionary commented 5 years ago

@kilbith Alright, I've removed the protection checks and logging. I suppose I can override the behaviour on our server if I really want to. The only code that remains is the bug fix and a little superfluous cleanup I did when I was poking at what was going on.

To continue my tangent, we tend to have a problem that anything that isn't nailed down gets griefed and stolen, even though doing such things is against the rules. I have no idea what a secure room is - players glitch through everything even when we're using area protection.