search

minetest-mods / xdecor

A decoration mod for Minetest meant to be light, simple and well-featured
Other
29 stars 45 forks source link

avoid race condition which results in duplicate book entities on the enchanting table #155

Closed fluxionary closed 2 years ago

fluxionary commented 2 years ago

because of a race condition, the check for whether to regenerate a book entity can happen while the entity is unloaded, resulting in multiple entities per enchanting table. on the your-land server, i've found at least one enchanting table with 391 (!) book entities over the same table.

the fix for this is to not save the entity w/ the mapblock, and to instead re-generate it every time the block is loaded.

fluxionary commented 2 years ago

also tried to PR https://github.com/minetest-mods/enchanting, but that's archived and locked for some reason?