search

minetest-mods / xdecor

A decoration mod for Minetest meant to be light, simple and well-featured
Other
29 stars 45 forks source link

Open question about xdecor elements and related standalone mods. #57

Closed t4im closed 6 years ago

t4im commented 8 years ago

Several xdecor elements exist as part of xdecor and as standalone mod.

To reduce maintenance and development efforts, it would be great if we could deduplicate these. For example by removing them from xdecor or by closing the standalone mod.

This decision could of course be made for each element individually.

What do you think? Which elements would you like to use separate of xdecor, which would you miss in xdecor?

Napiophelios commented 8 years ago

if a change must be made; I think it best to remove the duplicated items from the xdecor mod. I think either change you make someone will be unhappy with it. removing the items just seems like it would be easier on those maintaining them.

sofar commented 8 years ago

You have several options, but one in particular is highly efficient:

1) maintain these 4 mods in separate git repositories 2) take the code out of xdecor 3) create an xdecor_modpack that combines all 5 and releasing that in tarball format and post it in the forums

this allows game writers to continue to take parts of xdecor and not all of it, as well as solving the problem for most users that just want the whole thing, while removing the code duplication problem entirely.

verymilan commented 8 years ago

I would vote for submodules :)

sofar commented 8 years ago

Submodules can be used in the modpack tree, yes, I would not recommend using a submodule setup to pull a mod into another mod, since that will lead to obvious confusion.

verymilan commented 8 years ago

I would not recommend using a submodule setup to pull a mod into another mod, since that will lead to obvious confusion.

A good serveradmin always reads the instructions in the readme ;) Just my opinion.

Edit: i may missunderstood the modpack tree thing?

Wuzzy2 commented 8 years ago

I am for seperate mods for all 4 features listed in the first post.

kilbith commented 7 years ago

I fired out the crafting guide since it had obviously nothing to do in that mod : https://github.com/minetest-mods/xdecor/commit/6bd045e3de0988c08a5831e2b84fa763925afd65

Just a small note : my vision of xdecor was adding decorations that were not only simple decorations, but also interactive ones to make them more appealing. Hence why the full-blown chessboard is here.