search

minetest-mods / xdecor

A decoration mod for Minetest meant to be light, simple and well-featured
Other
29 stars 45 forks source link

Light propagates through solid nodes #61

Closed Wuzzy2 closed 8 years ago

Wuzzy2 commented 8 years ago

There's a serious bug in this mod: You used paramtype="light" for many nodes, even “solid” ones. I bet you misunderstood what this paramtype means. A side-effect of this is that it will cause light to propagate THROUGH the node, so if you place a torch behind a stone tile (for example), it glows! I am sure this is not intended. You need this paramtype for nodeboxes usually but for normal cubes you should only use this paramtype if you really want light to go through (like for leaves or glass). First I thought this attribute is only set for the runestone (this is actually pretty interesting, maybe let's keep the light propagation for this stone) but after a quick check I noticed this is set for pretty much every node.

t4im commented 8 years ago

It's the registration handler that needs some tweaking then, as it sets these automatically for most xdecor nodes. (Homedecor then, too, i'll take a look at both later).

"Serious" seems a bit exaggerated :-) It's not duplicating items, destroying the map, chests or crashing the server. It's an easy fixable visual glitch. Thanks for reporting it though.

t4im commented 8 years ago

Please take a look at #63. It's rather not setting paramtype by default now, except in a few selected situations, but that could of course mess with other nodes now. If you find anything, where this doesn't work, let me know.

t4im commented 8 years ago

768fcfe8194d9eaa6296acb439213c426ccf41cc