search

minetest-monitoring / mesecons_debug

Debugging stuff for mesecons
Other
2 stars 4 forks source link

rework mesecons debug to be more flexible #7

Closed fluxionary closed 2 years ago

fluxionary commented 2 years ago

I rewrote (much of) this mod in order to make it more useful for the "Your Land" server, and wanted to give you an option to incorporate part or all of the changes.

The main difference is that instead of penalizing mapblocks based on whether mesecons usage exceeds a fixed number of microseconds, the mod now penalizes things based on

  1. How over-loaded the server currently is (lag)
  2. How much of that load is due to mesecons itself
  3. How much a particular mapblock contributes to the overload.

Other changes:

The changes have yet to go through rigorous testing on the live server, though multiplayer testing on a dev server seemed to indicate things are working as I'd expect.

Any feedback would be appreciated, or feel free to just close/ignore this PR as overly-ambitious :)

BuckarooBanzay commented 2 years ago

Any feedback would be appreciated, or feel free to just close/ignore this PR as overly-ambitious :)

Wow, thats quite a lot of work but i think it is going in the right direction :+1:

Does that currently work well on the YL server?

fluxionary commented 2 years ago

Does that currently work well on the YL server?

It works well on the test server, but that's not totally representative of a live server. And YL isn't very machine-heavy in the first place. I don't have a timeline for when it will get installed on the live server, but I'll post updates as I think it's relevant.

fluxionary commented 2 years ago

Just an update. The code is finally live on the main server, and has at least one major bug - it doesn't seem to actually apply the penalties (!). I'm working on that, but probably won't get it resolved until at least tomorrow.

BuckarooBanzay commented 2 years ago

I'm working on that, but probably won't get it resolved until at least tomorrow.

no pressure ;)

fluxionary commented 2 years ago

Figured out why the penalty wasn't being applied, it's now going through another round of testing on the YL test server (will be a few days until I've got results).

fluxionary commented 2 years ago

The current version of the code is live on YL now, I'll hopefully post an update of how that goes, in a few days.

fluxionary commented 2 years ago

I'm personally happy with how the mod is performing on Your-Land.

BuckarooBanzay commented 2 years ago

I'm personally happy with how the mod is performing on Your-Land.

Nice :+1: do you intend to add more commits or can i go ahead with testing/merging?

fluxionary commented 2 years ago

Not planning on adding more commits at the moment, though perhaps I should document the use of the parameters.

BuckarooBanzay commented 2 years ago

tested it too on a pandorabox-test instance, no issues so far :+1: merging this...