search

minetest-monitoring / mesecons_ratelimiter

0 stars 0 forks source link

Adding new_glass:rgb_* #2

Open 6r1d opened 4 years ago

6r1d commented 4 years ago

I added something similar to RGB LEDs in a branch of my new_glass repo. Should we add it to the rate limiter?

BuckarooBanzay commented 3 years ago

I added something similar to RGB LEDs in a branch of my new_glass repo. Should we add it to the rate limiter?

Oh, hey, i just stumbled upon this by accident, i hadn't enabled the "watch" thing :confounded: Anyway: i don't think that makes sense, the ratelimiter just helps in some cases when triggered by a mesecons on/off flag from multiple sides, the rgb-glass is digilines only i think... :thinking:

6r1d commented 3 years ago

Anyway: i don't think that makes sense, the ratelimiter just helps in some cases when triggered by a mesecons on/off flag from multiple sides, the rgb-glass is digilines only i think... thinking

Hm-m, but should it be disabled yet?

I haven't introduced hex-color entry yet, playing with the kD-tree color translation idea here, so there's a chance that either GPU should be monitored doing the same calculation or that there will be a ton of calls to RGB glass (which will then proceed to call kD-tree cache to convert hex colors).

BuckarooBanzay commented 3 years ago

Uh, still, this repo is only about the action_on calls from mesecons and has nothing to do with digilines: https://github.com/minetest-monitoring/mesecons_ratelimiter/blob/2a1ab781e6ead1531365a542121d86adbf0287cb/api.lua#L24

your new_glass mod if digilines only, right?

(i think we are not talking about the same thing :thinking:)

6r1d commented 3 years ago

your new_glass mod if digilines only, right?

Correct.

(i think we are not talking about the same thing thinking)

That might be the case