search

minetest-tools / mcimport

71 stars 22 forks source link

New features #10

Closed ensonic closed 8 years ago

ensonic commented 8 years ago

Add more mappings. Convert more commands.

sofar commented 8 years ago

The minetest-lapis mod you point to is hopelessly broken and doesn't even have the right textures in github. If we add new mods, they should really be well-maintained and actually work.

sofar commented 8 years ago

The other 3 patches are fine. If you take out the lapis patch I'll merge this PR.

ensonic commented 8 years ago

I took the original lapis mod and uploaded a copy to my github account. This has the missing textures. The first patch has been adjusted to load the mod from the new location. It would be nice to have it in the minetestmods project, but I can't send a PR to create a new repo.

sofar commented 8 years ago

https://github.com/ensonic/minetest-lapis is missing, 404.

I'm very cautious about adding new mods, note that in my README I explicitly also state why I never added Lapis and I still am opposed to making cosmetic non-functional conversions.

Before adding lapis I really want to assure that the mod actually is properly OSS myself and the textures aren't copyrighted either.

sofar commented 8 years ago

Seems you just put the wrong url in lua. I wonder if @LNJ2 wants to maintain it in minetest-mods and take your patch? I'd be up for moving lapis to minetest-mods.

lnjX commented 8 years ago

Here is the newest version: https://github.com/LNJ2/lapis I just updated the README and added it to my real github-account. This mod was my first one, and as I wrote it I didn't even know how to use git (from the command line and not with the web-interface).

I already thought about moving it to minetest-mods.

sofar commented 8 years ago

@ensonic can you change it to minetest-mods/lapis and check it still works? Then I'll merge.

ensonic commented 8 years ago

Thanks, updated and tested!