search

minetest-tools / mcimport

71 stars 22 forks source link

Reimplement get-mods.sh as a Python script #29

Open vilhelmgray opened 4 years ago

vilhelmgray commented 4 years ago

Users no longer require sh, curl, unzip, or a *nix environment in order to automatically download the required mods. This should allow users of other operating systems such as Windows to also use this script.

Bug: https://github.com/minetest-tools/mcimport/issues/28

sofar commented 4 years ago

Is there a reason you changed the interface and made the argument a required thing?

This is a cli application (still) so no matter what, the user will need to execute it from a cmd.exe or a terminal.

vilhelmgray commented 4 years ago

Is there a reason you changed the interface and made the argument a required thing?

Thinking over this a second time, I realized that users wouldn't need to download the mods anywhere else. So I've removed the argument and reverted back to the original interface of simply executing the script in the new world folder directory.

This is a cli application (still) so no matter what, the user will need to execute it from a cmd.exe or a terminal.

Yes, I agree. I plan on submitting an update some time next week that will add in an optional gui, but that will be purely an alternative interface for convenience as mcimport.sh is now.

This particular get_mods patch is a prerequisite for the future optional gui patch I am writing, but is otherwise unrelated.

sofar commented 4 years ago

I would hold off on an actual GUI. If we go that route, I would rather make e.g. golang based binaries that can work entirely by themselves that have embedded gui libraries, so that it just works out of the box on any supported architecture, instead of having to install python, and then install python libraries, which is just way too complex for the type of user that I see asking for help with mcimport.

vilhelmgray commented 4 years ago

That's a fair point. I'll stop further development on a gui interface for now then.