minetest-tools / mcresconvert

Convert Minecraft Resource and Texture Packs to Minetest Texture Packs
35 stars 14 forks source link

half doors from the start trek ressource pack #16

Closed ensonic closed 7 years ago

ensonic commented 8 years ago

http://www.planetminecraft.com/texture_pack/chrisryots-star-trek-textures/

The converted doors only fill the upper half. Do we need to remap sections of the texture?

doors_door_wood

ensonic commented 8 years ago

The issue sees to be that the converter assumes that all images follow the same base size (or some defined ratio).

file blocks/cobblestone.png
blocks/cobblestone.png: PNG image data, 256 x 256, 8-bit/color RGB, non-interlaced
file blocks/door_wood_upper.png 
blocks/door_wood_upper.png: PNG image data, 128 x 128, 8-bit/color RGB, non-interlaced
sofar commented 8 years ago

Determining aspect ratio for each texture is possible, but complex because many textures are in a map or don't follow simple multiplier rules. That's of course a texture pack design error. I'm not so sure I feel like fixing this, since it's a corner case and most texture packs don't do this.

ensonic commented 8 years ago

Is there a reference for what the 'simple multiplier rules' should be? For now I'll probably fix up the source files and rerun the conversion. Would be nice if we could warn such files, but I guess we could also fix them in that case.

sofar commented 8 years ago

Right now, everything is determined as a multiplier of the cobblestone texture ($PX). Doors are therefore expected to be PX x 2PX (w x h) etc..