minetest-whynot / whynot-game

Minetest game in minetest mods collection style
GNU General Public License v3.0
14 stars 7 forks source link

[Mod Request]: `exchangeclone` #183

Open ThePython10110 opened 8 months ago

ThePython10110 commented 8 months ago

Request

This is the URL for the mod I would like to be added:

https://content.minetest.net/packages/ThePython/exchangeclone/

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • ExchangeClone is in no way a mandatory thing. If you don't want to use ExchangeClone stuff, you have absolutely no obligation.
  2. When could this mod be a strain on the server when no players are using the mod?
    • No ABMs are used, and there is only one globalstep function that runs every second and checks every player's inventory for certain items and runs actions if they are found. The only thing that could be affected is server load times.
  3. When does this mod destroy player's work?
    • Never.
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • I wrote the code, and all the problems I know of are listed under "Known Issues" in the readme.
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • Most of the individual files could be split into their own mods, although there are some that would have to depend on each other.
  6. Is this mod survival friendly? What items that it provides that should be craftable/obtainable, but aren't?
    • Everything is craftable, although there is a setting that disables the crafting recipe for the Alchemical Tome (soon to be renamed to Tome of Knowledge).
  7. When does this mod feel like cheating?
    • The basic premise of this mod is that every item has an EMC value (cobble is 1, diamonds are 8,192, etc). You can convert between items based on the EMC value. So you can turn 1 diamond into 8,192 cobblestone. There are also easy ways of passively generating EMC (maybe too easy). The EMC values can be adjusted in zzzz_exchangeclone_init/base_energy_values.lua.
    • Due to an engine bug, the armor can make you invincible.
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • See "Known Issues" in the readme.
  10. Is the licence one that we can include in WhyNot? (Whynot is under the GPLv3 only. Be sure you know what you are talking about or cite your source)
    • Yes (GPLv3+)

Other comments

This mod is based on a Minecraft mod called ProjectE, and also includes many features from ProjectExpansion, an expansion mod for ProjectE.

Lazerbeak12345 commented 8 months ago

I've actually been eyeing this one for awhile! I'm excited to see it in the game.

Lazerbeak12345 commented 8 months ago

I'm a bit worried about this. Needs playtest:

Dark and Red Matter Armor can make the player invincible. This is an engine problem that I can't fix.

Lazerbeak12345 commented 8 months ago

Also, added git repo to OP