[Mod Request]: `orienteering`

[dacmot]

URL for mod to be added

https://content.minetest.net/packages/Wuzzy/orienteering/

Reasons why I think this game would be a good addition to the WhyNot? game

Terraria-like craft chain of geographical and time information items that help players finding their ways around a map (and back).

1. In what ways might this mod take over the game?

It doesn't. Just tools.

2. When could this mod be a strain on the server when no players are using the mod?

It has a globalstep function to update the player stats. In theory, with a lot of players, it could add some computation time. The server Blocky Survival uses it...

3. When does this mod destroy player's work?

It doesn't. Just tools.

4. Have you looked at the code? If so, what stood out as things that might need fixing?

Mostly looks good. The globalstep function was bugging me so I submitted some optimizations. Also saying "MIT License" is a bit vague.

• [ ] Global step
• [x] Clarify license

5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")

It seemed fairly simple. I don't think it could be made simpler.

6. Is this mod survival friendly? What items that it provides that should be craftable/obtainable, but arent?

Yes, survival friendly. The craft chain makes it progressive, with harder to get materials, and a final all-in-one item.

7. When does this mod feel like cheating?

I don't think it does. It simply helps with navigation. No teleporting.

8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).

yes. https://codeberg.org/Wuzzy/minetest_orienteering

9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?

No errors noticed.

10. Is the licence one that we can include in WhyNot? (Whynot is under the GPLv3 only. Be sure you know what you are talking about or cite your source)

Yes. "Everything is licensed under MIT License."

[dacmot]

Code reviewed (with comments - see above).

[dacmot]

I get a feeling Wuzzy does not like my suggested optimizations. Been sitting on them for several months now.

In any case, I have a fork with the optimizations, and a personal preference to change the x,z,y coordinates to lat/lon/alt for more a more real-world relatable nomenclature.

I'll open a PR for adding my fork. Let me know what you think there.

[Lazerbeak12345]

Either look fine to me tbh. Up to Wuzzy ofc