search

minetest-whynot / whynot-game

Minetest game in minetest mods collection style
GNU General Public License v3.0
14 stars 7 forks source link

skinsdb mod assertion failure during launch #196

Closed Lazerbeak12345 closed 1 month ago

Lazerbeak12345 commented 1 month ago

Problem

This error is logged in the server

2024-07-17 18:21:55.658572216 2024-07-17 18:21:55: ERROR[Main]: .../.minetest/games/whynot-game/mods/player/skinsdb/api.lua:79: attempt to index local 'file' (a nil value) 2024-07-17 18:21:55.658573814 2024-07-17 18:21:55: ERROR[Main]: stack traceback: 2024-07-17 18:21:55.658575368 2024-07-17 18:21:55: ERROR[Main]: .../.minetest/games/whynot-game/mods/player/skinsdb/api.lua:79: in function 'get_skin_format' 2024-07-17 18:21:55.658584492 2024-07-17 18:21:55: ERROR[Main]: ...etest/games/whynot-game/mods/player/skinsdb/skinlist.lua:78: in function 'register_skin' 2024-07-17 18:21:55.658585940 2024-07-17 18:21:55: ERROR[Main]: ...etest/games/whynot-game/mods/player/skinsdb/skinlist.lua:145: in main chunk 2024-07-17 18:21:55.658593886 2024-07-17 18:21:55: ERROR[Main]: [C]: in function 'dofile' 2024-07-17 18:21:55.658601976 2024-07-17 18:21:55: ERROR[Main]: ....minetest/games/whynot-game/mods/player/skinsdb/init.lua:13: in main chunk

Steps to reproduce

latest version, launch server

Expected behavior

The server should start instead of asserting

Minetest client version

Minetest 5.8.0 (Linux) (5.8.0-2)

WhyNot? Game version

2024-07-16 (latest)

Operating system/version

Artix Linux

Installation

Downloaded with git

Additional mods enabled in your world (ex. technics, mobs_animals, etc.)

xban2 we_undo vote vote_kick protector worldedit worldedit_brush worldedit_commands worldedit_gui worldedit_shortcommands latency_protection

Lazerbeak12345 commented 1 month ago

may be related to 81c577eb63b3faae44bf91d541ad483547427685

dacmot commented 1 month ago

I don't get that error when starting a new game. Do you have skins or otherwise make use of skinsdb?

Lazerbeak12345 commented 1 month ago

Good question, should have had that written down. I had downloaded a collection of skins from that website they link(ed?) to (which is now down). I suspect this has something to do with their migration to a new filename pattern.

This one: https://web.archive.org/web/20210402134646/http://minetest.fensta.bplaced.net/

From how long ago that site was replaced with https://skinsdb.terraqueststudios.net/ I'd be almost certain that an old format was in-use.

Lazerbeak12345 commented 1 month ago

I mostly just opened the issue here to determine if it should even be reported upstream.

dacmot commented 1 month ago

The update_skins.py script seems to refer to that terraqueststudios.net address.

In any case, not cool of them to break backwards compatibility like that. Should file a bug report upstream.

In the meantime, I can make a new release with that commit reverted.

Lazerbeak12345 commented 1 month ago

That fixed it for now. I'll report upstream later - when I am not worn out.

Lazerbeak12345 commented 1 month ago

Issue reported upstream, but it seems to be intermittent. ~~I haven't gotten it to happen again. ~~

dacmot commented 1 month ago

Did you remember to put the change back in? :stuck_out_tongue_winking_eye:

Lazerbeak12345 commented 1 month ago

Ah, sorry. If you look upstream I've gotten it to happen again but it's not consistent.

Lazerbeak12345 commented 1 month ago

Fixed in upstream