Open jeroenrnl opened 3 years ago
Duplicate of #29
This is the URL for the modpack I would like to be added:
https://content.minetest.net/packages/Jeija/mesecons
Refer to the Whynot Readme for full rule descriptions/reasons.
We already have many of the mods within this modpack. We currently are expressly excluding several. We only need to review the code for the missing
Seeing that we are splitting the issue that this was marked as a duplicate of (see the review of homedecor) I don't think this is a duplicate anymore.
Here's the code that is excluding some of the mesecons mods:
This, therefore, is the list of mods to be considered.
Review for mesecons_luacontroller
Refer to the Whynot Readme for full rule descriptions/reasons.
The mesecon restriction mod applies a fix for rule 2 here.
Updated licence info
Review for mesecons_commandblock
Refer to the Whynot Readme for full rule descriptions/reasons.
Review for mesecons_detector
Refer to the Whynot Readme for full rule descriptions/reasons.
Review for mesecons_fpga
Refer to the Whynot Readme for full rule descriptions/reasons.
Review for mesecons_gates
Refer to the Whynot Readme for full rule descriptions/reasons.
Review for mesecons_hydroturbine
Refer to the Whynot Readme for full rule descriptions/reasons.
Review for mesecons_microcontroller
Refer to the Whynot Readme for full rule descriptions/reasons.
Review for mesecons_stickyblocks
Refer to the Whynot Readme for full rule descriptions/reasons.
All sub-requests made... I'll doublecheck as I prepare the draft PR I'll use to review the code.
Working on evaluating rule 9 right now... I won't be spending much time on this due to the massive quantity of these items.
I think I can safely argue that a playtest indicates everything is fine so long as lag limits are in place. Further, those limits should not prevent singleplayer from doing things - just other users. (IE: for servers, we need a lag limit, but for single player it doesn't matter)
Is there a reason why only a part of the mesecon modpack is included? For example
mesecon_gates
and a few others are not in whynot.Finished playest for these mods:
mesecons_luacontroller
mesecons_commandblock
mesecons_detector
mesecons_fpga
mesecons_gates
mesecons_hydroturbine
mesecons_microcontroller
mesecons_stickyblocks
Section added by @Lazerbeak12345 to make this actionable.