search

minetest-whynot / whynot-game

Minetest game in minetest mods collection style
GNU General Public License v3.0
14 stars 7 forks source link

Mesecon mod incomplete #41

Open jeroenrnl opened 3 years ago

jeroenrnl commented 3 years ago

Is there a reason why only a part of the mesecon modpack is included? For example mesecon_gates and a few others are not in whynot.

Finished playest for these mods:

Section added by @Lazerbeak12345 to make this actionable.

bell07 commented 3 years ago

Duplicate of #29

Lazerbeak12345 commented 2 years ago

Request

This is the URL for the modpack I would like to be added:

https://content.minetest.net/packages/Jeija/mesecons

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this modpack take over the game?
    • It doesn't.
  2. When could this modpack be a strain on the server when no players are using the mod?
    • Some of the more complicated mesecon logics lag the server while they run - and may not require direct player interaction.
  3. When does this modpack destroy player's work?
    • TODO research
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • no. TODO needs done.
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • It's pretty well split.
  6. Is this modpack survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • Yes. None have that issue.
  7. When does this modpack feel like cheating?
    • Never. If you consider automation cheating, keep in mind that mesecon ore, crystals, blocks are balanced to be mid-late-game.
  8. Does this modpack use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • TODO test with full modpack.
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

We already have many of the mods within this modpack. We currently are expressly excluding several. We only need to review the code for the missing

Seeing that we are splitting the issue that this was marked as a duplicate of (see the review of homedecor) I don't think this is a duplicate anymore.

Lazerbeak12345 commented 2 years ago

Here's the code that is excluding some of the mesecons mods:

https://github.com/minetest-whynot/whynot-game/blob/9b49b31842c9d921d1b12330f25a5750a517230c/builder/lib-config-whynot.sh#L20

This, therefore, is the list of mods to be considered.

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_luacontroller

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • It shouldn't.
  2. When could this mod be a strain on the server when no players are using the mod?
    • It runs lua code, triggered by input events. These input events could be on a clock, so this can be a lot of code running.
  3. When does this mod destroy player's work?
    • It can't.
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • Yes. UNKNOWN NEEDS CODE REVIEW
  7. When does this mod feel like cheating?
    • Up for debate, but instead of connecting mesecon wires or other things like that, you write code for a microcontroller. I think this could be balanced if it's expensive enough. TODO what does it cost?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • TODO test in the context of whynot
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

The mesecon restriction mod applies a fix for rule 2 here.

Lazerbeak12345 commented 1 year ago

Updated licence info

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_commandblock

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • None.
  2. When could this mod be a strain on the server when no players are using the mod?
    • Runs commands automatically.
  3. When does this mod destroy player's work?
    • When the command block owner is capable of running a command to destroy that player's work. (Not an issue)
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • yes.
    • No problems
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • none. it's as simple as it can get.
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • Yes. Surprisingly very much so. Commands can only be ran that the owner of the command block can run.
  7. When does this mod feel like cheating?
    • Automated processes - but i'd argue never.
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_detector

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
  2. When could this mod be a strain on the server when no players are using the mod?
  3. When does this mod destroy player's work?
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
  7. When does this mod feel like cheating?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_fpga

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
  2. When could this mod be a strain on the server when no players are using the mod?
  3. When does this mod destroy player's work?
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
  7. When does this mod feel like cheating?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_gates

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
  2. When could this mod be a strain on the server when no players are using the mod?
  3. When does this mod destroy player's work?
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
  7. When does this mod feel like cheating?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_hydroturbine

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
  2. When could this mod be a strain on the server when no players are using the mod?
  3. When does this mod destroy player's work?
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
  7. When does this mod feel like cheating?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_microcontroller

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
  2. When could this mod be a strain on the server when no players are using the mod?
  3. When does this mod destroy player's work?
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
  7. When does this mod feel like cheating?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

Lazerbeak12345 commented 1 year ago

Request

Review for mesecons_stickyblocks

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
  2. When could this mod be a strain on the server when no players are using the mod?
  3. When does this mod destroy player's work?
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
  7. When does this mod feel like cheating?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
  10. LICENCE
    • LGPL-3.0-only (not an issue)

Other comments

Lazerbeak12345 commented 1 year ago

All sub-requests made... I'll doublecheck as I prepare the draft PR I'll use to review the code.

Lazerbeak12345 commented 8 months ago

Working on evaluating rule 9 right now... I won't be spending much time on this due to the massive quantity of these items.

Lazerbeak12345 commented 5 months ago

I think I can safely argue that a playtest indicates everything is fine so long as lag limits are in place. Further, those limits should not prevent singleplayer from doing things - just other users. (IE: for servers, we need a lag limit, but for single player it doesn't matter)

Lazerbeak12345 commented 5 months ago