Open bell07 opened 2 years ago
edit to above: linked to git diff
List of code changes from that diff:
/README.txt
wool
farming
bonemeal
skeletons
unified_inventory
skinsdb
get_meta
then get_string
instead of get_attribute
clothing.lua
and colors_pictures.lua
.obj
files when a single key-framed .obj would work instead.obj
file would work insteaddepends.txt
mod.conf
appliances
multiskin
sfinv
creative
inventory_plus
unified_inventory
wool
bucket
default
farming
bonemeal
skeletons
basic_materals
clothing_enable_craft
clothing_register_clothes
clothing_character
clothing_enable_hood_mask
I may have missed some, feel free to comment or edit to add them.
Perhaps we should have a goal/rule for Whynot to fit in a ranking within (at least one) specific game rating system. It would have to be unofficially, unless we know of a way to get it officially rated that is free. I'll make this comment as an issue at some later time, if there's more push to get this sfence fork into whynot.
A note: the questionable thing I'm referencing can be disabled via a setting.
Added mod.conf
I think many of the checkboxes I pointed out might not be enough of problems to block. So long as we change that one setting I mentioned, we could move forward with this.
rule review, since we somehow missed doing this:
Looked into new skinsdb support now: 2 new skins are added: Male and female in underwear. Parameter to set the male to the default skin The parameter overrides the default skin texture. I proposed the change to proper replace the default skin: https://github.com/sfence/clothing/issues/13
* Dye machines, looms and the spinning machine are using seperate `.obj` files when a single key-framed .obj would work instead
I use generated .obj from Minetest schematic in
.we
format. I don't know how to do key-framed.obj
files But I am open to updating it if someone brings a better 3D model.* Spinnning machine is using attached nodes when a single animated `.obj` file would work instead
What do you mean by attached nodes?
* [ ] Uses generic appliances api? Undocumented dep?
Should be documented now, see https://github.com/sfence/appliances/blob/master/API.md
Updated rules check
I don't like the new skinsdb dependency. It creates a circular one because skinsdb also depends on clothing. As a result, skinsdb can't be listed in optional dependencies.
It looks to me like the dependency on skinsdb in this mod is extraneous. Clothing is about adding clothes, not skins. If people want a naked skin, they should be able to use one, sure. But I don't think it should be the clothing mod's job to make it available.
Originally posted by @dacmot in https://github.com/sfence/clothing/issues/14#issuecomment-1995925652
sfence created a fork of clothing mod and did a lot of changes.
https://github.com/sfence/clothing/tree/v2
If we like to change to this mod, we need to reconsider if this fork still match the whynot rules