search

minetest-whynot / whynot-game

Minetest game in minetest mods collection style
GNU General Public License v3.0
14 stars 7 forks source link

Whynot rules for homedecor #65

Open bell07 opened 2 years ago

bell07 commented 2 years ago

Homedecor was initially all-in-one mod, one of the first mods in my mods collection. The rule 5 was defined because of homedecor, but my childs liked the mod content, therefore the mod was not removed. After the mod was splitted into modpack, I removed some of them because of Art-clash or redundancy (3d_extras, computers).

Still outstanding is to check all homedecor mods separatelly for whynot rules. Maybe we need a new rule for Art-Style?

Mod Comment
building_blocks
fake_fire
homedecor_3d_extras not in whynot because of wrong art style
homedecor_bathroom
homedecor_bedroom
homedecor_books
homedecor_climate_control
homedecor_clocks
homedecor_cobweb
homedecor_common
homedecor_doors_and_gates
homedecor_electrical
homedecor_electronics
homedecor_exterior
homedecor_fences
homedecor_foyer
homedecor_furniture
homedecor_furniture_medieval
homedecor_gastronomy
homedecor_inbox
homedecor_kitchen
homedecor_laundry
homedecor_lighting
homedecor_misc
homedecor_office
homedecor_pictures_and_paintings
homedecor_plasmascreen
homedecor_roofing some redundancy with myroofs
homedecor_seating
homedecor_tables
homedecor_trash_cans
homedecor_wardrobe
homedecor_windows_and_treatments
itemframes
lavalamp
home_workshop_modpack/home_vending_machines
home_workshop_modpack/home_workshop_misc

Section added by @Lazerbeak12345 to make this actionable

Mods that have basic research finished: (reference to the project this issue is attached to)

Lazerbeak12345 commented 2 years ago

Review for this mod:

building_blocks

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • Lots of craftable nodes? Perhaps not an issue.
  2. When could this mod be a strain on the server when no players are using the mod?
    • Never.
  3. When does this mod destroy player's work?
    • Never.
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • Yes.
    • Some names could be clearer. When looking at them in recipes.lua I had already forgotten many of them, and the name didn't help much.
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • Seems to serve as a catch-all. Perhaps just a better file structure would fix this?
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • fakegrass block is confusing for survival gameplay.
  7. When does this mod feel like cheating?
    • Never
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • [ ] #90 (this is already handled in whynot_compat but it's worth a mention)
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 2 years ago

Updated above assessment to have content

Lazerbeak12345 commented 1 year ago

Review for this mod:

fake_fire

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 1 year ago

Concerning rule 10, all mods within homedecor are LGPL 3.0 (only or later not specified, either are compatible) with CC by SA 4.0 for "media and all other [non-code] assets". Rule 10 is not/will not be an issue for these mods.

Lazerbeak12345 commented 3 months ago

Doing some work to make this issue more actionable

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_3d_extras

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_bathroom

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_bedroom

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_books

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_climate_control

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_clocks

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_cobweb

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_common

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Gonna take a break on this issue for today.

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_doors_and_gates

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_electrical

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 3 months ago

Review for this mod:

homedecor_electronics

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0

Lazerbeak12345 commented 1 month ago

Review for this mod:

homedecor_exterior

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • UNKNOWN
  2. When could this mod be a strain on the server when no players are using the mod?
    • UNKNOWN
  3. When does this mod destroy player's work?
    • UNKNOWN
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • UNKNOWN
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • UNKNOWN. UNKNOWN
  7. When does this mod feel like cheating?
    • UNKNOWN
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • UNKNOWN
  10. Licence:

    • License for code: LGPL 3.0 License for media and all other assets: CC-by-SA 4.0