search

minetest-whynot / whynot-game

Minetest game in minetest mods collection style
GNU General Public License v3.0
14 stars 7 forks source link

Whynot rules for minetest_game mods #67

Open bell07 opened 2 years ago

bell07 commented 2 years ago
To be fair, the mods collection was started on top of Minetest Game, therefore these mods was never checked against the Whynot Rules.... Mod Status
beds ok
binoculars Seems to be just tech-demo. But why not ;-)
boats
bones
bucket
butterflies
carts enhanced by boost_cart
creative mandatory base
default mandatory base
doors
dungeon_loot
dye
env_sounds not in whynot because of ambience
farming not in whynot because of TenPlus1 farming fork
fire
fireflies
flowers mandatory base for colors
game_commands
give_initial_stuff unused by default. But why not ;-)
map
mtg_craftguide not in whynot because of craftguide
player_api (WIP) #62
screwdriver
sethome
sfinv mandatory base
spawn
stairs ok
tnt
vessels
walls ok
weather
wool ok
xpanes ok

Section added by @Lazerbeak12345 to make this issue actionable

Mods that have basic info complete (see linked project):

Lazerbeak12345 commented 2 years ago

Seems to be just tech-demo. Remove?

I don't think this is a problem. No rules broken by that mod.

bell07 commented 2 years ago

Thanks, you reminded me what the whynot stands for ;-)

Lazerbeak12345 commented 2 years ago

On this topic: It might be a good idea to ignore the "take over the game" rule for MTG mods, as default does for sure, as do several other mods from MTG.

Lazerbeak12345 commented 2 years ago

My only complaint about the boats mod, having read the code, is this:

Many minetest mods that make their own rideable thing, such as lib_mount or vehicles or mobkit always seem to copy this code into their library, instead of using an API. The reason? This mod doesn't provide that API, and the API it does provide is far too boat-specific to be useful for that sort of thing.

But that isn't technically breaking any of the rules, so I think the boats mod is fine.

(my other complaint is that there's only one boat: boats:boat, and it was named badly)

Lazerbeak12345 commented 2 years ago

Review

I'm reviewing the beds mod in this comment.

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • None.
  2. When could this mod be a strain on the server when no players are using the mod?
    • No.
  3. When does this mod destroy player's work?
    • No.
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • None.
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • Yes. The bed is not craftable.
  7. When does this mod feel like cheating?
    • Never
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • Yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • None.

Other comments

Lazerbeak12345 commented 2 years ago

Licences aren't a problem with any of these mods. Code lgpl, media various versions of CC SA

Lazerbeak12345 commented 8 months ago

added todo checklist to move it to next slot in the project

Minor network lag may have caused duplicate pings

Lazerbeak12345 commented 7 months ago

Review

I'm reviewing the binoculars mod in this comment.

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • None.
  2. When could this mod be a strain on the server when no players are using the mod?
    • No.
  3. When does this mod destroy player's work?
    • No.
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • None.
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • Yes.
  7. When does this mod feel like cheating?
    • Lets you see quite far, but it costs a lot
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • Yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • None.

Other comments

Lazerbeak12345 commented 3 weeks ago

Review

I'm reviewing the boats mod in this comment.

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • None.
  2. When could this mod be a strain on the server when no players are using the mod?
    • Perhaps entities? Likely not (they only move when player is interacting afaik)
  3. When does this mod destroy player's work?
    • No.
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • No. UNKNOWN
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • None.
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
    • Yes.
  7. When does this mod feel like cheating?
    • Unsure
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • Yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • None.

Other comments