[Modpack Request]: `plantlife`

[Lazerbeak12345]

Request

This is the URL for the modpack I would like to be added:

https://github.com/mt-mods/plantlife_modpack

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this modpack take over the game?
   • Adds "kibble" to lots of things. I don't think it's an issue, as it looks good.
2. When could this mod be a strain on the server when no players are using the modpack?
   • Never.
3. When does this modpack destroy player's work?
   • It doesn't.
4. Have you looked at the code? If so, what stood out as things that might need fixing?
   • No. THIS NEEDS DONE.
5. In what way might this modpack be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
   • Likely not, as this is a modpack.
6. Is this modpack survival freindly? What items that it provides that should be craftable/obtainable, but arent?
   • Yes. None have that issue.
7. When does this modpack feel like cheating?
   • It doesn't.
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • yes
9. Upon testing this modpack, what errors, odd behavior, or other incompatibilities were noticed?
   • [ ] Sunflower issue https://github.com/minetest-whynot/whynot-game/issues/82#issuecomment-1153338963
   • [ ] Plant quantity https://github.com/minetest-whynot/whynot-game/issues/82#issuecomment-1153338963
10. compatible licence
    • yes, LGPL v3

Other comments

This was split from #32

This is a modpack. Each mod within should be reviewed individually.

• [x] 3dmushrooms @BruceMustache recommended not including this for now. (I think it's fine, but more research pending)
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] bushes
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] bushes_classic
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] cavestuff
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] dryplants
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] ferns
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] molehills
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] nature_classic
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] pl_seaweed
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] pl_sunflowers
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] pl_waterlilies
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] poisonivy
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] trunks
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] vines
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] woodsoils
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)
• [ ] youngtrees - A personal favorite of mine.
  • [x] Basics
  • [x] Playtest
  • [ ] Code Review (do in a PR?)

[dacmot]

Rule 8... NO. New url needed!

What's wrong with the current URL? Seems to work for me.

[bell07]

Sorry, I replaced the URL without comment the change

[Lazerbeak12345]

Updated to reflect results of playtest.

I'm unsure if rule one is an issue or not. I think it's in good taste - and the decor can be removed very easily - but it isn't something that can be disabled, and effects most of the world (usually for the better, I think)

[dacmot]

Playing it now. It does add nice variety of plants, though mostly in non-deserted areas (probably for obvious reasons). I really like the vines in the jungle. On the other hand, I do find it a bit overwhelming in the grasslands. Maybe we could set the rarity so that it's not as full of grass and bushes.

Another small problem is now there are two different sunflowers (one in farming_redo already). It should be possible to disable the plantlife one with the max count and/or rarity setting.

[Lazerbeak12345]

Better than disabling spawning of one type of sunflower might be to send a PR to one or the other repo to either make them compatible (like the two types of bones are) or to alias them.

[Lazerbeak12345]

Request

3dmushrooms from the plantlife modpack

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this mod take over the game?
   • None
2. When could this mod be a strain on the server when no players are using the mod?
   • Never
3. When does this mod destroy player's work?
   • Never
4. Have you looked at the code? If so, what stood out as things that might need fixing?
   • Yes. Nothing
5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
   • Nothing
6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
   • Yes.
7. When does this mod feel like cheating?
   • Never
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • Yes
9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
   • None.
10. Licence
    • LGPLv3.0

Other comments

Seems that awhile ago it was stripped down and simplified, with aliases to default 'shrooms. Not an issue at all, but that means all this mod does is change how those mushrooms look.

[Lazerbeak12345]

updated OP to include rule 10

[Lazerbeak12345]

Updated review for 3dmushrooms.

[dacmot]

Looks good to me for 3d mushrooms. Would you like to create a PR for it?

[Lazerbeak12345]

I was thinking about doing all of plantlife - or all of it that qualifies - all in one PR. What do you think?

[dacmot]

OK. From a maintenance point of view, the whole modpack would be added anyway. Just a blacklist in lib-config-whynot.sh if we want to do it one by one.

[Lazerbeak12345]

Added some concerns from @dacmot to issue 9

[Lazerbeak12345]

Request

bushes from the plantlife modpack

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this mod take over the game?
   • This mod in particular is the mod that adds... all the bushes. There's a lot of them.
2. When could this mod be a strain on the server when no players are using the mod?
   • Never.
3. When does this mod destroy player's work?
   • Never.
4. Have you looked at the code? If so, what stood out as things that might need fixing?
5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
6. Is this mod survival friendly? What items that it provides that should be craftable/obtainable, but arent?
7. When does this mod feel like cheating?
   • Never
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • Yes
9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
   • None.
10. Licence
    • LGPLv3.0

Other comments

[Lazerbeak12345]

Request

bushes_classic from the plantlife modpack

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this mod take over the game?
   • None
2. When could this mod be a strain on the server when no players are using the mod?
   • None
3. When does this mod destroy player's work?
   • Never
4. Have you looked at the code? If so, what stood out as things that might need fixing?
5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
   • None
6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
   • Yes
7. When does this mod feel like cheating?
   • Never
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • Yes
9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
   • None
10. Licence
    • LGPLv3.0

Other comments

[Lazerbeak12345]

Request

cavestuff from the plantlife modpack

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this mod take over the game?
   • None
2. When could this mod be a strain on the server when no players are using the mod?
   • Never
3. When does this mod destroy player's work?
   • Never
4. Have you looked at the code? If so, what stood out as things that might need fixing?
5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
   • None
6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
   • Yes
7. When does this mod feel like cheating?
   • Never
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • Yes
9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
   • None
10. Licence
    • LGPLv3.0

Other comments

[Lazerbeak12345]

Request

dryplants from the plantlife modpack

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this mod take over the game?
   • None
2. When could this mod be a strain on the server when no players are using the mod?
   • Never
3. When does this mod destroy player's work?
   • Never
4. Have you looked at the code? If so, what stood out as things that might need fixing?
5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
   • None
6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
   • Yes
7. When does this mod feel like cheating?
   • Never
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • Yes
9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
   • None
10. Licence
    • LGPLv3.0

Other comments

[Lazerbeak12345]

Request

ferns from the plantlife modpack

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

1. In what ways might this mod take over the game?
   • None
2. When could this mod be a strain on the server when no players are using the mod?
   • Never
3. When does this mod destroy player's work?
   • Never
4. Have you looked at the code? If so, what stood out as things that might need fixing?
5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
   • None
6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
   • Yes
7. When does this mod feel like cheating?
   • Never
8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
   • Yes
9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
   • Never
10. Licence
    • LGPLv3.0

Other comments

[Lazerbeak12345]

bushes playtested.

[Lazerbeak12345]

I playtested all at once. We can do the code review all at once too.