minetest-world / mtlauncher

GNU Lesser General Public License v2.1
5 stars 3 forks source link

implement contentdb mods + recursive lookup for dependencies #2

Open recluse4615 opened 2 years ago

recluse4615 commented 2 years ago

hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

can mostly copy games/ but need to be a bit smarter about things, for a few reasons:

recluse4615 commented 2 years ago

everything on contentdb can ask for "hard dependencies" which need to be resolved: https://github.com/minetest-world/mtlauncher/blob/main/src/lib/api/contentdb.js#L31

if a package has any hard dependencies, we need to:

we should also include the scores from https://content.minetest.net/api/scores/ in to the getContent() function

we then have a list of packages in the form of {author}/{package}, we need to:

we should provide feedback to the user as this is happening, by showing some "installing X/Y packages... current package {name}" eg:

Installing 1/2 packages
current package "mobs"
Miniontoby commented 2 years ago

Status update:

The code is getting close to be done, only the feedback thingy has to be added and maybe some improvements in the listing, but that will have to come also at #3

Also there is one issue: Going to mods and then going to games (after mods already loaded) will actually make the games tab to show no mods. (this also works the other way round). So we will have to fix that as well

UPDATE: Fixed the issue that I found by using derived to clone the content variable and filter the content. Also I added the feedback thingy.

I think that once #23 is approved I can already submit the code and this will be able to be marked as done

recluse4615 commented 10 months ago

This should be resolved with #24 , I will confirm this