search

minetest-world / mtlauncher

GNU Lesser General Public License v2.1
5 stars 3 forks source link

Added Mods Tab #24

Closed Miniontoby closed 7 months ago

Miniontoby commented 1 year ago

Added the mods tab for #2

Also made the games tab better by using the same logic as for the mods tab to make the cache not be overwritten when filtering

Miniontoby commented 1 year ago

first off - thank you for your work! i really appreciate you taking the time to do all of this, and i'm really happy to see that my creation justifies it :)

i've added a number of comments - most of them just small nitpicks - but other than that i would suggest we create a separate branch to test this (rather than just merging directly in to main) since it's a fairly big task

Sounds good, we can do it, but it will be difficult to merge them if the main branch will be changed and also a file from the other branch are changed...

Miniontoby commented 8 months ago

FOr some reason it committed more than I wanted, so Yeah I guess I will just implement translations in this PR as well.

I will make sure it builds using an github action. -> https://github.com/Miniontoby/mtlauncher/actions/runs/7513785380 <- it does! -> Only publish release failed, since I already had the 0.0.5 tag... But yeah, you can try it out: https://github.com/Miniontoby/mtlauncher/releases/tag/v0.0.5

recluse4615 commented 7 months ago

@Miniontoby there's a lot going on in this PR - I am going to merge this, but in to a new branch (dev) so that I can pull it and run a full e2e test, as your GH actions build doesn't work for me.

Thank you so much for your work (and dealing with my shoddy response times!)