minetest / contentdb

A content database for Minetest mods, games, and more
https://content.minetest.net
GNU Affero General Public License v3.0
93 stars 45 forks source link

markdown support seems full in review editor, but isnt #304

Closed AFCMS closed 3 years ago

AFCMS commented 3 years ago

Summary

image image

Steps to reproduce

try

rubenwardy commented 3 years ago

Strikethroughs aren't supported by the Markdown "spec", they're a common extension but not part of Markdown itself

The correct fix to this is to enable the extension in the markdown parser

AFCMS commented 3 years ago

but it seems it works in editor, so why not in real review? :thinking:

rubenwardy commented 3 years ago

The editor is a separate piece of software to ContentDB. It's a JavaScript library, I didn't write it. It appears to have more extensions enabled by default

AntumDeluge commented 3 years ago

Does ContentDB's markdown implementation support <del> tag?

Edit: Nope. I just tested it. It does not.

AntumDeluge commented 3 years ago

There are however, issues with tables. They work in the description & the previewer, but don't display correctly in comments:

ContentDB_comment_tables

Edit: I take part of that back, they don't display correctly in the description either.

AntumDeluge commented 3 years ago

Also, I just learned that GitHub & Discord markdown implementations support enclosing with double tildes (~) for strikethrough:

~~deleted~~ = deleted

Edit: Interestingly, ContentDB's editor shows it as supporting tildes, but does not work when saved or previewed:

ContentDB_strikethrough

Edit: Oh, that's what you were talking about @rubenwardy: "It appears to have more extensions enabled by default"

Edit: You know what, other than about the tables, you can just ignore everything else I said (that's what I get for skimming through the thread). 🙂