minetest / contentdb

A content database for Minetest mods, games, and more
https://content.minetest.net
GNU Affero General Public License v3.0
95 stars 46 forks source link

Don't automatically check "digest" when "instant" is checked. #556

Open RokeJulianLockhart opened 1 month ago

RokeJulianLockhart commented 1 month ago

Problem

As mentioned at https://forum.minetest.net/viewtopic.php?p=438257#p438257:

At https://content.minetest.net/users/RokeJulianLockhart/settings/email/, I cannot disable digests but enable instant notifications. I have no need for digests, because I triage each notification individually in my e-mail client.

As https://github.com/minetest/contentdb/issues/556#issuecomment-2282820910 explains, this isn't actually enabling the digest mail for that issue type:

This is just a quirk of the UI - notifications won't be sent in the digest if they've already been sent "instantly"

However, this causes two issues:

  1. Those who want both do not receive both - merely the more specific of the two.
  2. Those who want merely instant notifications are unnecessarily duped into believing that they are to be sent two notifications per type.

Solutions

Allow the user to disable "digest"-type notifications for notification types irrespective of whether the user is subscribed to them as "instant"-type.

Alternatives

I haven't thought of any.

rubenwardy commented 1 month ago

This is just a quirk of the UI - notifications won't be sent in the digest if they've already been sent "instantly"

RokeJulianLockhart commented 1 month ago

https://github.com/minetest/contentdb/issues/556#issuecomment-2282820910

@rubenwardy, I'll re-scope the issue, then. Thanks.