search

minetest / irrlicht

Minetest's fork of Irrlicht
Other
115 stars 87 forks source link

IrrlichtMt target does not export SDL includes as PUBLIC #148

Closed JosiahWI closed 1 year ago

JosiahWI commented 1 year ago

It's just flat out incorrect, and it's kind of hilarious that it didn't break for anybody until now. ${SDL_INCLUDES} should be added to the public include directories.

sfan5 commented 1 year ago

Should it? I don't see any SDL_*.h referenced in the 'include' folder.

JosiahWI commented 1 year ago

This is only an issue if source/CIrrDeviceSDL.h is included anywhere in the public includes. I may have sounded a false alarm.

JosiahWI commented 1 year ago

I haven't looked in detail but I think this can be closed. Sorry about that.

sfan5 commented 1 year ago

Okay.