search

minetest / irrlicht

Minetest's fork of Irrlicht
Other
115 stars 87 forks source link

Drop IrrCompileConfig #163

Closed numberZero closed 1 year ago

numberZero commented 1 year ago

Close #158. It may be easier to review commit-by-commit.

numberZero commented 1 year ago

Raw logic behind IrrCompileConfig: SVG version PNG version

numberZero commented 1 year ago

My understanding of logic behind IrrCompileConfig: SVG PNG version

JosiahWI commented 1 year ago

You may have already considered this, but moving some of the platform-dependent configuration to a separate script might be good.

numberZero commented 1 year ago

moving some of the platform-dependent configuration to a separate script

From CMakeLists? Maybe but I’d prefer to get rid of most of it instead.

And @sfan5, I think this PR is ready to review now.

JosiahWI commented 1 year ago

moving some of the platform-dependent configuration to a separate script

From CMakeLists? Maybe but I’d prefer to get rid of most of it instead.

I'm suggesting a CMake script, to keep src/CMakeLists.txt uncluttered.