search

minetest / irrlicht

Minetest's fork of Irrlicht
Other
114 stars 87 forks source link

Android CI #197

Closed numberZero closed 8 months ago

numberZero commented 1 year ago

Add Android CI. Mostly a copy from minetest_android_deps where Irrlicht was added before forking.

An alternative would be to use build.sh directly from that repo. But keeping the build script separate from own code makes little sense IMO. A better approach could be to only import _setup_toolchain to ensure compatibility but that requires some changes in the deps repo.

numberZero commented 1 year ago

Note: the CI passes on its own commit, a8326353167ed40d1e4e0311ac4047c778f59a61: https://github.com/numberZero/irrlicht/actions/runs/4778460794/jobs/8494894748. The failure is due to later changes in this repo (the “pull request” checks run on the merge result).

numberZero commented 1 year ago

Now that Android fixes are in master, this simply works. Didn’t test whether the Irrlicht the CI builds works too, though.

sfan5 commented 1 year ago

Maybe we can just clone https://github.com/minetest/minetest_android_deps and run the build from there? I'm not too happy about so much duplication.

numberZero commented 1 year ago

Maybe we can just clone https://github.com/minetest/minetest_android_deps and run the build from there? I'm not too happy about so much duplication.

JPEG and PNG don’t need to be built here at all anymore as they’re available in the deps since https://github.com/minetest/minetest_android_deps/pull/4. But for Irrlicht itself, it’d be rather awkward to keep the build script in a separate repository. For the environment setup it’s possible but copy it or import it, it will be fragile either way.

sfan5 commented 8 months ago

I decided my opinion is wrong.