search

minetest / irrlicht

Minetest's fork of Irrlicht
Other
115 stars 87 forks source link

Delete obsolete stuff #240

Closed numberZero closed 1 year ago

numberZero commented 1 year ago

Delete bin, lib and doc, keeping only the license from the latter.

sfan5 commented 1 year ago

The build system places its files there so at least that has to (or should) be adjusted too.

Desour commented 1 year ago

The build system places its files there so at least that has to (or should) be adjusted too.

Tested (with out-of-tree and in-tree build). The paths are created automatically. I don't see an issue.

irr-readme.txt has some author names. Should we keep them? Or link to https://irrlicht.sourceforge.io/?page_id=301 somewhere maybe?

numberZero commented 1 year ago

The build system places its files there so at least that has to (or should) be adjusted too.

At least on Linux, it places the files in identically named directories in the build directory. You don’t build in-tree, do you?

irr-readme.txt has some author names. Should we keep them? Or link to https://irrlicht.sourceforge.io/?page_id=301 somewhere maybe?

Maybe. But, the comments are largely historical. And, note this: “this list hasn't been updated in a while, but they are often mentioned in changes.txt”. And there is no changes.txt.

I think a simple link to the original project may be more appropriate. Something like “Based on the Irrlicht Engine”.

sfan5 commented 1 year ago

At least on Linux, it places the files in identically named directories in the build directory

I thought the idea was to get rid of them too, that's why I mentioned it.

You don’t build in-tree, do you?

I do in fact.