225 removed IRR_COMPILE_WITH_WINDOWS_DEVICE. Windows builds now always include the Windows Irrlicht device. However, SDL builds must only contain the SDL Irrlicht device. If both the Windows device and the SDL device exist, the Windows device takes precedence:
As a result, USE_SDL2 has no effect anymore on Windows. I suggest reverting #225 for now to make these builds work again, the PR can always be redone correctly later.
How to reproduce
Compile Minetest with -DUSE_SDL2=TRUE on Windows. See that the "About" tab still shows "Irrlicht device: WIN32".
This doesn't seem to be the same issue as #239, the CI still fails after reverting #225.
@nerzhul
225 removed
IRR_COMPILE_WITH_WINDOWS_DEVICE. Windows builds now always include the Windows Irrlicht device. However, SDL builds must only contain the SDL Irrlicht device. If both the Windows device and the SDL device exist, the Windows device takes precedence:https://github.com/minetest/irrlicht/blob/9954667c45cc6c184ead60b516e532111556e56a/source/Irrlicht/Irrlicht.cpp#L58-L97
As a result,
USE_SDL2has no effect anymore on Windows. I suggest reverting #225 for now to make these builds work again, the PR can always be redone correctly later.How to reproduce
Compile Minetest with
-DUSE_SDL2=TRUEon Windows. See that the "About" tab still shows "Irrlicht device: WIN32".This doesn't seem to be the same issue as #239, the CI still fails after reverting #225.