Update minimum CMake version

minetest / irrlicht

Minetest's fork of Irrlicht

Other

115 stars 87 forks source link

Update minimum CMake version #270

Closed jordan4ibanez closed 10 months ago

jordan4ibanez commented 10 months ago

Cmake in engine currently very old.

Give it a few birthdays so we can use newer features.

We are missing the ability to add link libraries to object library targets. We'd like this for the glTF development.

appgurueu commented 10 months ago

This depends on https://github.com/minetest/irrlicht/pull/272

sfan5 commented 10 months ago

What for? Are we missing any features?

JosiahWI commented 10 months ago

We are missing the ability to add link libraries to object library targets. We'd like this for the glTF development, and I'd like it for the Irrlicht CMakeLists as well to help clean it up.

sfan5 commented 10 months ago

ok in that case:

Debian 10: 3.13 :heavy_check_mark:
RHEL 8 derivates: seems to differ but 3.18 is available :heavy_check_mark:
Ubuntu 20.04: 3.16 :heavy_check_mark:

verdict: we can do this

jordan4ibanez commented 10 months ago

yay

jordan4ibanez commented 10 months ago

Do we have to do anything else?

sfan5 commented 10 months ago

https://github.com/minetest/irrlicht/pull/270#issuecomment-1877944665:

This depends on #272