search

minetest / irrlicht

Minetest's fork of Irrlicht
Other
115 stars 87 forks source link

Specify dependencies on object library targets #282

Open JosiahWI opened 5 months ago

JosiahWI commented 5 months ago

The minimum CMake version was updated to 3.12 in #270. This cleans up the build using the feature to use target_link_libraries on object library targets that was added in CMake 3.12.

It has been tested on Linux with OpenGL. I will test it with more settings and on more systems as the work progresses.

numberZero commented 5 months ago

Can’t you just replace target_sources with linking to the object libraries?

JosiahWI commented 5 months ago

Can’t you just replace target_sources with linking to the object libraries?

I'm planning to try that. I expect it may work, but I was also concerned that it might resolve the symbols but not include them in the archive. That would require the .o files to be installed, and that's not what we want, right? 🙂