minetest / irrlicht

Minetest's fork of Irrlicht
Other
115 stars 87 forks source link

Upgrade actions in CI #290

Closed wsor4035 closed 9 months ago

wsor4035 commented 9 months ago

Add compact, short information about your PR for easier understanding:

To do

This PR is a Work in Progress

Outside the scope of just upgrading actions

lukka/run-vcpkg@v7 - https://github.com/minetest/minetest/pull/14377#discussion_r1493006875

How to test

use your eyes to check actions reports

wsor4035 commented 9 months ago

two failing appear to be unrelated to changes made in this pr

sfan5 commented 9 months ago

Not unrelated but this bug was previously hidden. You can change the msvc workflows to only upload the sdl artifacts for example.

wsor4035 commented 9 months ago

Not unrelated but this bug was previously hidden. You can change the msvc workflows to only upload the sdl artifacts for example.

could this also be solved by changing https://github.com/minetest/irrlicht/blob/master/.github/workflows/build.yml#L261 to be msvc-${{ matrix.config.arch }}-${{matrix.sdl.use}} potentially? thoughts?

sfan5 commented 9 months ago

Yes. Either works.

wsor4035 commented 9 months ago

in theory fixed (see when tests finish in ... )